Skip to content

[Dashboard] Remove react-icons (2) #4983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2024
Merged

[Dashboard] Remove react-icons (2) #4983

merged 1 commit into from
Oct 10, 2024

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Oct 10, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on updating icon imports across various components in the dashboard application, switching from react-icons to lucide-react icons for a more consistent and modern iconography.

Detailed summary

  • Replaced FiMenu with MenuIcon in MobileMenu.tsx.
  • Updated FiSearch to SearchIcon in HackathonFooter.tsx.
  • Changed FiArrowRight to MoveRightIcon in TWQueryTable.tsx.
  • Substituted BsFillLightningChargeFill with ZapIcon in HomePageCard.tsx and HeroSection.tsx.
  • Replaced BsShieldCheck with ShieldCheckIcon in PublishedContract.tsx.
  • Updated FiArrowRight and FaEllipsisVertical to MoveRightIcon and EllipsisVerticalIcon respectively in TWTable.tsx.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 3:00pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 10, 2024 3:00pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 10, 2024 3:00pm
wallet-ui ⬜️ Skipped (Inspect) Oct 10, 2024 3:00pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: ba9a7d4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 10, 2024 06:10 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 10, 2024 06:10 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 10, 2024 06:10 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@kien-ngo kien-ngo marked this pull request as ready for review October 10, 2024 06:10
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 10, 2024
@kien-ngo Graphite App
Copy link
Contributor Author

kien-ngo commented Oct 10, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite Graphite

@kien-ngo kien-ngo mentioned this pull request Oct 10, 2024
Merged
@codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.74%. Comparing base (c776943) to head (ba9a7d4).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4983   +/-   ##
=======================================
  Coverage   47.74%   47.74%           
=======================================
  Files        1059     1059           
  Lines       57328    57328           
  Branches     3944     3944           
=======================================
  Hits        27369    27369           
  Misses      29268    29268           
  Partials      691      691
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from c776943
packages 43.53% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.07 KB (0%) 842 ms (0%) 921 ms (-4.04% 🔽) 1.8 s
thirdweb (cjs) 101.87 KB (0%) 2.1 s (0%) 1.7 s (-10.27% 🔽) 3.7 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 48 ms (+48.78% 🔺) 145 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 15 ms (+1.66% 🔺) 25 ms
thirdweb/react (minimal + tree-shaking) 17.24 KB (0%) 345 ms (0%) 279 ms (+158.1% 🔺) 624 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 10, 2024 •
edited by MananTank
Loading

Merge activity

@kien-ngo
[Dashboard] Remove react-icons (2) (#4983)
ba9a7d4 
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating icon imports from `react-icons` to `lucide-react` across several components, enhancing consistency and potentially reducing bundle size.

### Detailed summary
- Replaced `FiMenu` with `MenuIcon` in `MobileMenu.tsx`.
- Replaced `FiSearch` with `SearchIcon` in `HackathonFooter.tsx`.
- Replaced `FiArrowRight` with `MoveRightIcon` in `TWQueryTable.tsx`.
- Replaced `BsFillLightningChargeFill` with `ZapIcon` in `HomePageCard.tsx` and `HeroSection.tsx`.
- Replaced `BsShieldCheck` with `ShieldCheckIcon` in `PublishedContract`.
- Replaced `FiArrowRight` and `FaEllipsisVertical` with `MoveRightIcon` and `EllipsisVerticalIcon` in `TWTable.tsx`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the kien/remove-react-icons-1 branch from d786d40 to c776943 Compare October 10, 2024 14:50
@MananTank MananTank force-pushed the kien/remove-react-icons-2 branch from 5f74347 to ba9a7d4 Compare October 10, 2024 14:51
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 10, 2024 14:51 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 10, 2024 14:51 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 10, 2024 14:51 Inactive
Base automatically changed from kien/remove-react-icons-1 to main October 10, 2024 15:00
@graphite-app graphite-app bot merged commit ba9a7d4 into main Oct 10, 2024
29 checks passed
@graphite-app graphite-app bot deleted the kien/remove-react-icons-2 branch October 10, 2024 15:01
@vercel vercel bot temporarily deployed to Production – wallet-ui October 10, 2024 15:01 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 10, 2024 15:01 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 10, 2024 15:01 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MananTank MananTank MananTank approved these changes

@jnsdls jnsdls Awaiting requested review from jnsdls

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kien-ngo @MananTank